Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Manage http errors for stateful tractograms #3025

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

skoudoro
Copy link
Member

@skoudoro skoudoro commented Jan 2, 2024

This PR provides an alternative when there is http issue with fetch_gold_standard_io.

Instead of failing, we just skip the tests and provide a reason. It also one step further concerning offline testing (see #2647)

It also cleanup some global variable.

@pep8speaks
Copy link

pep8speaks commented Jan 2, 2024

Hello @skoudoro, Thank you for updating !

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated at 2024-01-02 19:29:53 UTC

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8caa6c5) 82.08% compared to head (bf47b9e) 82.06%.
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3025      +/-   ##
==========================================
- Coverage   82.08%   82.06%   -0.02%     
==========================================
  Files         146      146              
  Lines       20467    20467              
  Branches     3261     3261              
==========================================
- Hits        16800    16797       -3     
- Misses       2856     2859       +3     
  Partials      811      811              
Files Coverage Δ
dipy/core/sphere.py 93.30% <82.35%> (ø)

... and 1 file with indirect coverage changes

@skoudoro
Copy link
Member Author

skoudoro commented Jan 8, 2024

Anyone to look at this ?

I will wait until Wednesday and then go ahead and merge if no objection.

@skoudoro
Copy link
Member Author

ok, I am going ahead and merge this.

@skoudoro skoudoro merged commit 191d34c into dipy:master Jan 10, 2024
31 checks passed
@skoudoro skoudoro deleted the http-stateful branch January 10, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants