Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NF] Add DSI workflow #3073

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

skoudoro
Copy link
Member

This PR just add DSI Workflow.

You can test it by run this cli on taiwan_ntu_dsi DIPY Dataset

@pep8speaks
Copy link

pep8speaks commented Feb 22, 2024

Hello @skoudoro, Thank you for updating !

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated at 2024-02-28 16:43:37 UTC

@skoudoro
Copy link
Member Author

Not sure why so many tests are failing.

Failing tests are not related to this PR.

Its seems related to setup_moduleand teardown_module.

I also see that there is a new release of Pytest (from last week). I will try to reproduce that locally.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.39%. Comparing base (aa1768d) to head (4c80175).
Report is 24 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3073      +/-   ##
==========================================
+ Coverage   82.37%   82.39%   +0.02%     
==========================================
  Files         146      146              
  Lines       20631    20662      +31     
  Branches     3319     3323       +4     
==========================================
+ Hits        16995    17025      +30     
  Misses       2805     2805              
- Partials      831      832       +1     
Files Coverage Δ
dipy/io/peaks.py 95.34% <100.00%> (+0.03%) ⬆️
dipy/workflows/cli.py 42.85% <ø> (ø)
dipy/workflows/reconst.py 76.53% <90.90%> (+0.89%) ⬆️

... and 2 files with indirect coverage changes

@Garyfallidis Garyfallidis merged commit bf2f63c into dipy:master Mar 5, 2024
28 of 30 checks passed
@skoudoro skoudoro deleted the add-dsi-workfows branch March 5, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants