Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed 4d slice issue #3084

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

maharshi-gor
Copy link
Member

This PR is for the issue #3075

It introduces the fix for when the volume slider is accessed the 3D slices stops working for that specific slice.

Root cause

The display_extent of the slice actor was changed via a partial and was given an initial object. But while accessing the volume we create new actors for that specific volume value. But when we move the slider it access the old objects, hence providing no updates on ui.

Fix

  • The partials are moved to a function which is called again when the volume is changed and new actors are created.

@maharshi-gor maharshi-gor self-assigned this Feb 27, 2024
@maharshi-gor maharshi-gor added the category:visualization everything related to viz label Feb 27, 2024
@Garyfallidis Garyfallidis merged commit 197f558 into dipy:master Feb 27, 2024
4 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:visualization everything related to viz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants