FVTK small improvement: Arbitrary matplotlib colormaps can be used to color spherical functions #339
Conversation
| @@ -32,6 +32,8 @@ | |||
| vtk, have_vtk, setup_module = optional_package('vtk') | |||
| colors, have_vtk_colors, _ = optional_package('vtk.util.colors') | |||
|
|
|||
| import matplotlib | |||
There was a problem hiding this comment.
We're trying to keep matplotlib as an optional dependency for now. Take a look at the import here:
https://github.com/nipy/dipy/blob/master/dipy/viz/projections.py#L12
There was a problem hiding this comment.
Ah! I can fix that and adapt the code
There was a problem hiding this comment.
Yep - as easy as "copy-paste" :-)
On Fri, Mar 14, 2014 at 10:54 AM, Demian Wassermann <
notifications@github.com> wrote:
In dipy/viz/fvtk.py:
@@ -32,6 +32,8 @@
vtk, have_vtk, setup_module = optional_package('vtk')
colors, have_vtk_colors, _ = optional_package('vtk.util.colors')+import matplotlib
Ah! I can fix that and adapt the code
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/339/files#r10619060
.
|
Hey @demianw - just checking in with you about this one. Have you had a chance to do that copy-paste operation? |
|
Hey @arokem , thanks for the follow-up. I'm abroad until next week. I will perform the modifications next week |
|
OK - just wanted to make sure it doesn't slip through the cracks. Thanks! On Tue, Mar 25, 2014 at 1:03 PM, Demian Wassermann <notifications@github.com
|
|
Sorry for the time that took. I just merged that manually (after checking locally on my machine). |
|
Perfect, thanks! |
Small update to allow any matplotlib colormap to be used in the colouring of spherical functions