Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matplotlib optional #52

Merged
merged 10 commits into from Aug 12, 2012
Merged

Matplotlib optional #52

merged 10 commits into from Aug 12, 2012

Conversation

arokem
Copy link
Contributor

@arokem arokem commented Aug 4, 2012

This should make the Travis bot a bit less cranky

@travisbot
Copy link

This pull request fails (merged b353e52d into 898a401).

@arokem
Copy link
Contributor Author

arokem commented Aug 4, 2012

Hang on. This has some weird merge commits attached to it. Let me fix the history of this thing first.

@arokem
Copy link
Contributor Author

arokem commented Aug 4, 2012

OK - fixed the history on this thing. Ready to go now

@travisbot
Copy link

This pull request fails (merged 44c55d9 into 898a401).

@travisbot
Copy link

This pull request fails (merged 814802a into 898a401).

@travisbot
Copy link

This pull request fails (merged 56d7bda into 898a401).

@arokem
Copy link
Contributor Author

arokem commented Aug 4, 2012

OK - at this point travisbot is not complaining about matplotlib anymore. I'll move on to try to deal with the doctest errors here as well.

@travisbot
Copy link

This pull request fails (merged 92f8a20 into 898a401).

@arokem
Copy link
Contributor Author

arokem commented Aug 4, 2012

OK - I think I'm done here. Remaining test failures are now:

  1. set_odf_vertices: related to the API RF.
  2. _filter_peaks: related to the API RF.
  3. GeneralizedQSampling: related to the API RF.
  4. ravel_multi_index: Is ravel_multi_index a new thing?  #53

@travisbot
Copy link

This pull request fails (merged d0ed95e into 898a401).

Bago Amirbekian and others added 2 commits August 6, 2012 11:30
@travisbot
Copy link

This pull request fails (merged 00231ed into 898a401).

@MrBago
Copy link
Contributor

MrBago commented Aug 7, 2012

This doc-test fails on my machine (I have matplotlib), the specifics are bellow. Maybe we should replace the doctest with a test file. If you would like to leave the example, but not have it run as a doctest you can replace the >>> with >>.

$ nosetests dipy/viz/projections.py --with-doctest
F
======================================================================
FAIL: Doctest: dipy.viz.projections.sph_project
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/netopt/epd_py27-7.1-2/lib/python2.7/doctest.py", line 2166, in runTest
    raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for dipy.viz.projections.sph_project
  File "/home/bagrata/projects/dipy/dipy/viz/projections.py", line 30, in sph_project

----------------------------------------------------------------------
File "/home/bagrata/projects/dipy/dipy/viz/projections.py", line 63, in dipy.viz.projections.sph_project
Failed example:
    sph_project(verts,np.random.rand(len(verts)))
Expected nothing
Got:
    <matplotlib.axes.AxesSubplot object at 0x192415d0>

-------------------- >> begin captured logging << --------------------
apptools.preferences.preferences: DEBUG: loading preferences from </home/bagrata/.enthought/mayavi_e3/preferences.ini>
apptools.preferences.preferences: DEBUG: loading preferences from <<closed file '/netopt/epd_py27-7.1-2/lib/python2.7/site-packages/mayavi/preferences/preferences.ini', mode 'rb' at 0x155e66f0>>
apptools.preferences.preferences: DEBUG: loading preferences from <<closed file '/netopt/epd_py27-7.1-2/lib/python2.7/site-packages/tvtk/plugins/scene/preferences.ini', mode 'rb' at 0x155e6ae0>>
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 1 test in 1.682s

FAILED (failures=1)

@travisbot
Copy link

This pull request fails (merged de458ba into 898a401).

@arokem
Copy link
Contributor Author

arokem commented Aug 11, 2012

@MrBago Does this do the trick for you?

@travisbot
Copy link

This pull request fails (merged 7d104a4 into 898a401).

@travisbot
Copy link

This pull request fails (merged 1a2403c into 898a401).

@stefanv
Copy link
Contributor

stefanv commented Aug 11, 2012

Looks good to me!

@arokem
Copy link
Contributor Author

arokem commented Aug 12, 2012

Shall we merge this?

On Sat, Aug 11, 2012 at 3:01 PM, Stefan van der Walt <
notifications@github.com> wrote:

Looks good to me!


Reply to this email directly or view it on GitHubhttps://github.com//pull/52#issuecomment-7670658.

stefanv added a commit that referenced this pull request Aug 12, 2012
RF - Make Matplotlib an optional import
@stefanv stefanv merged commit 6b18cc9 into dipy:master Aug 12, 2012
MarcCote pushed a commit to MarcCote/dipy that referenced this pull request Mar 2, 2018
ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants