BF: memleaks with typed memory views in Cython #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx! Cool debugging and thank you for discovering another cython bug! I hope your reported this. You have some minor pep8 issues on your tests. Fix them in another PR please. Not crucial for now. Thx much! |
Garyfallidis
added a commit
that referenced
this pull request
Oct 20, 2015
BF: memleaks with typed memory views in Cython
|
Yes, I made a post explaining the problem and attached some code to reproduce the bug. Last time I did this they confirmed the bug and opened a issue in their bug tracker pretty quickly. However, as of now, it is still not fixed :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refcount is not decreased when converting a numpy array, previously defined in Python space (i.e. not in the .pyx file), into a Cython typed memory view.
The workaround is to create a copy of the numpy array using
astypewhile in Cython space. Luckily for us, most of the time no data is copied, only metadata (i.e. when the dtype stays the same).Fixes #737