Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF - fixup peaks_from_model to take use remove_similar_vertices and #81

Merged
merged 2 commits into from Oct 9, 2012

Conversation

MrBago
Copy link
Contributor

@MrBago MrBago commented Oct 8, 2012

I added a return_index keyword to remove_similar_vertices so that we could let go of _filter_peaks.

sphere : Sphere
A discrete sphere used to evaluate the odf.
relative_peak_threshold : float
Peaks smaller than this threshold, relative to the largest peak, are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we had a more descriptive docstring for this before. Was that in another function?

@stefanv
Copy link
Contributor

stefanv commented Oct 8, 2012

Looks good to me.

@MrBago MrBago mentioned this pull request Oct 9, 2012
@Garyfallidis
Copy link
Contributor

Travis fails :(

File "/usr/local/lib/python2.7/dist-packages/dipy/sims/voxel.py", line 257, in dipy.sims.voxel.multi_tensor_odf
1039Failed example:
1040 odf = multi_tensor_odf(vertices, [0.5,0.5], mevals, mevecs)
1041Exception raised:
1042 Traceback (most recent call last):
1043 File "/usr/lib/python2.7/doctest.py", line 1289, in __run
1044 compileflags, 1) in test.globs
1045 File "<doctest dipy.sims.voxel.multi_tensor_odf[8]>", line 1, in
1046 odf = multi_tensor_odf(vertices, [0.5,0.5], mevals, mevecs)
1047 NameError: name 'vertices' is not defined

@MrBago
Copy link
Contributor Author

MrBago commented Oct 9, 2012

I re-based this onto the fixed master and it's passing now.

Garyfallidis added a commit that referenced this pull request Oct 9, 2012
RF - fixup peaks_from_model to take use remove_similar_vertices and
@Garyfallidis Garyfallidis merged commit e2963c1 into dipy:master Oct 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants