New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RF: Use cython imports instead of relying on extern #1228
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1228 +/- ##
=======================================
Coverage 85.88% 85.88%
=======================================
Files 221 221
Lines 27285 27285
Branches 2785 2785
=======================================
Hits 23435 23435
Misses 3165 3165
Partials 685 685 Continue to review full report at Codecov.
|
Use calloc etc from libc.stdlib, and memset, memcpy from libc.string.
Finishing up stdlib import removals at MarcCote#10 . |
RF: finish removing extern stdlib imports
@matthew-brett thanks. @arokem this PR is ready. |
Darn. Should've probably asked you to rebase on master before merging. Looks like this broke the master branch: https://travis-ci.org/nipy/dipy/jobs/224600749. Any idea how these things interact? |
Error is:
I immediately can't think of any way the stdlib imports could cause a change at at the 7th decimal place, only for Cython 0.25.1 / numpy 1.7.1. Maybe there's some randomness in the test? |
You're right. This is also relatively new, so might just be the precision wasn't set appropriately: #1231 To answer your question: yes, there is some randomness in that test: https://github.com/nipy/dipy/blob/master/dipy/reconst/tests/test_dki_micro.py#L88-L89 |
RF: Use cython imports instead of relying on extern
Small refactoring as suggested by @matthew-brett (see comment #1076 (comment))