[FIX] check seeds dtype #2044
[FIX] check seeds dtype #2044
Conversation
dipy/tracking/local_tracking.py
Outdated
| @@ -79,6 +80,9 @@ def __init__(self, direction_getter, stopping_criterion, seeds, affine, | |||
| raise ValueError("step_size must be greater than 0.") | |||
| if maxlen < 1: | |||
| raise ValueError("maxlen must be greater than 0.") | |||
| if not isinstance(seeds, Iterable): | |||
| raise ValueError("seeds should be a list of 3D points. Please" | |||
There was a problem hiding this comment.
This seems a bit confusing to me. The first sentence says the input should be a list and then the second sentence says it should be an array. I think either is fine? Could you please clarify that?
|
Looks like conda on OSX is having a bad morning. Have you seen that one before? |
|
Yes, I saw that on FURY. Sometimes, it is just a server problem and we have to be patient. Sometimes, the lastest miniconda version is just not working correctly so we have to downgrade the miniconda version and not get the latest one. I will wait a bit to commit my change and let's see. |
Codecov Report
@@ Coverage Diff @@
## master #2044 +/- ##
==========================================
+ Coverage 90.37% 91.15% +0.77%
==========================================
Files 247 247
Lines 31525 31595 +70
Branches 3314 3322 +8
==========================================
+ Hits 28492 28801 +309
+ Misses 2298 2071 -227
+ Partials 735 723 -12
|
|
YLGTM. Since this is small, and has already gone through one round of review, I will go ahead and merge this now. |
A small PR to fix #2034. I just check the
seedtype to avoid an error later with a much more complex message.