Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve some CI's script typo #2628

Merged
merged 2 commits into from Jan 23, 2023
Merged

resolve some CI's script typo #2628

merged 2 commits into from Jan 23, 2023

Conversation

skoudoro
Copy link
Member

This is a quick PR to solve some typos in different CI's shell scripts

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #2628 (41ae694) into master (551fa1c) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2628   +/-   ##
=======================================
  Coverage   83.83%   83.83%           
=======================================
  Files         131      131           
  Lines       18292    18293    +1     
  Branches     2979     2980    +1     
=======================================
+ Hits        15335    15336    +1     
  Misses       2220     2220           
  Partials      737      737           
Impacted Files Coverage Δ
dipy/tracking/streamline.py 93.83% <0.00%> (+0.02%) ⬆️

@skoudoro
Copy link
Member Author

it seems the CI fails on windows + parallelization due to a memory leak (https://github.com/dipy/dipy/runs/7544106844?check_suite_focus=true#step:9:3495).

to introspect before merging.

@skoudoro skoudoro changed the title [FIX] resolve some CI's script typo [WIP] resolve some CI's script typo Aug 30, 2022
@skoudoro skoudoro changed the title [WIP] resolve some CI's script typo resolve some CI's script typo Jan 23, 2023
@skoudoro
Copy link
Member Author

This PR is ready to go. It would be great if someone could merge it.

If no answer by Wednesday, I will go ahead and merge it.

Thanks!

@arokem arokem merged commit a2cb9ad into dipy:master Jan 23, 2023
@skoudoro skoudoro deleted the ci-typo branch January 23, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants