Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Miscellaneous docstring fixes #2672

Merged
merged 3 commits into from Oct 31, 2022

Conversation

jhlegarreta
Copy link
Contributor

  • DOC: Fix parameter name in docstring
  • DOC: Mark optional parameters as such in docstring
  • DOC: Add parameter description to docstring

@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #2672 (c3c00ee) into master (1c2ac38) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2672      +/-   ##
==========================================
- Coverage   84.26%   84.25%   -0.01%     
==========================================
  Files         131      131              
  Lines       18106    18106              
  Branches     2930     2930              
==========================================
- Hits        15257    15256       -1     
  Misses       2119     2119              
- Partials      730      731       +1     
Impacted Files Coverage Δ
dipy/workflows/denoise.py 83.83% <ø> (ø)
dipy/workflows/multi_io.py 74.64% <ø> (ø)
dipy/reconst/forecast.py 90.00% <0.00%> (-0.50%) ⬇️
dipy/denoise/patch2self.py 74.31% <0.00%> (ø)

Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you some additional doc fixes ?

dipy/workflows/denoise.py Show resolved Hide resolved
dipy/workflows/multi_io.py Show resolved Hide resolved
Fix parameter name in docstring.

Take advantage of the commit to fix the same typo in the value
(filename) of the parameter.
Mark optional parameters as such in docstring.
Add parameter description to docstring.
Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jhlegarreta, merging

@skoudoro skoudoro merged commit 6cf2ec2 into dipy:master Oct 31, 2022
@jhlegarreta jhlegarreta deleted the MiscDocstringFixes branch October 31, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants