Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Nibabel InTemporaryDirectory #2797

Merged
merged 2 commits into from
May 3, 2023
Merged

Conversation

skoudoro
Copy link
Member

@skoudoro skoudoro commented May 2, 2023

InTemporaryDirectory or TemporaryDirectory is deprecated in Nibabel in favor of the standard package tempfile.

So this PR clean a bit our codebase

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #2797 (7f7c8a2) into master (1f5f7e2) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2797      +/-   ##
==========================================
- Coverage   81.49%   81.47%   -0.02%     
==========================================
  Files         143      143              
  Lines       20051    20051              
  Branches     3192     3192              
==========================================
- Hits        16340    16337       -3     
- Misses       2904     2906       +2     
- Partials      807      808       +1     

see 3 files with indirect coverage changes

@skoudoro
Copy link
Member Author

skoudoro commented May 3, 2023

This one is ready to go !

@arokem arokem merged commit ecff0b9 into dipy:master May 3, 2023
27 checks passed
@skoudoro skoudoro deleted the remove-nib-tmpdir branch December 16, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants