Remove the Deprecating nisext #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arokem
reviewed
May 3, 2023
| @@ -1,7 +1,5 @@ | |||
| """ Distutils / setuptools helpers for versioning | |||
|
|
|||
| This code started life in the nibabel package as nisexts/sexts.py | |||
There was a problem hiding this comment.
I'd suggest leaving this comment in, maybe adding a comment that it has been deprecated upstream in nibabel.
There was a problem hiding this comment.
This file will be removed before the end of the summer (september). This is a way to start the process 😄
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2800 +/- ##
==========================================
- Coverage 81.49% 81.47% -0.02%
==========================================
Files 143 143
Lines 20051 20051
Branches 3192 3192
==========================================
- Hits 16340 16336 -4
- Misses 2904 2907 +3
- Partials 807 808 +1 |
|
Thank you @arokem for the review. All green, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nibabel has deprecated
nisext. We were almost not using those tools. After checking, onlycheck-fileswas usedsometimes. Also, those tools depends ondistutilsthat we plan to remove completely.This is why this PR remove completely
nisextsince this is a package that we will not use in a close future. it also allowNibabelto move forward.Thanks for all the good services
nisext!closes #2706