Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vara's week 3 blog #2828

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Vara's week 3 blog #2828

merged 4 commits into from
Aug 11, 2023

Conversation

lb-97
Copy link
Contributor

@lb-97 lb-97 commented Jun 16, 2023

No description provided.

Copy link
Contributor

@shilpiprd shilpiprd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good!

@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Merging #2828 (4aeadef) into master (3e9caf8) will increase coverage by 0.01%.
Report is 23 commits behind head on master.
The diff coverage is n/a.

❗ Current head 4aeadef differs from pull request most recent head be066a0. Consider uploading reports for the commit be066a0 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2828      +/-   ##
==========================================
+ Coverage   81.47%   81.48%   +0.01%     
==========================================
  Files         144      144              
  Lines       20054    20055       +1     
  Branches     3192     3192              
==========================================
+ Hits        16339    16342       +3     
  Misses       2906     2906              
+ Partials      809      807       -2     

see 3 files with indirect coverage changes

@lb-97 lb-97 requested a review from pjsjongsung June 26, 2023 20:19
Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lb-97,

Overall, it looks good. See below few comments.

Do not hesitate to split in paragraph. it will make you text more readable.

doc/posts/2023/2023_06_12_vara_week3.rst Outdated Show resolved Hide resolved
doc/posts/2023/2023_06_12_vara_week3.rst Outdated Show resolved Hide resolved
@skoudoro
Copy link
Member

skoudoro commented Aug 8, 2023

Hi @lb-97, What is the update concerning this ?

@skoudoro
Copy link
Member

Thank you for the update @lb-97 . Can you do split in multiple block like you did in the blog week4 ? thank you in advance

@lb-97
Copy link
Contributor Author

lb-97 commented Aug 10, 2023

Thank you for the update @lb-97 . Can you do split in multiple block like you did in the blog week4 ? thank you in advance

Done!

@skoudoro
Copy link
Member

Thanks for the update @lb-97, merging

@skoudoro skoudoro merged commit 72f7902 into dipy:master Aug 11, 2023
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants