Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vara's week 4 blog #2831

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Vara's week 4 blog #2831

merged 1 commit into from
Aug 10, 2023

Conversation

lb-97
Copy link
Contributor

@lb-97 lb-97 commented Jun 19, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 20, 2023 •
edited

Codecov Report

Merging #2831 (ef068a0) into master (3e9caf8) will increase coverage by 0.00%.
Report is 19 commits behind head on master.
The diff coverage is n/a.

❗ Current head ef068a0 differs from pull request most recent head 597a7e5. Consider uploading reports for the commit 597a7e5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2831   +/-   ##
=======================================
  Coverage   81.47%   81.48%           
=======================================
  Files         144      144           
  Lines       20054    20054           
  Branches     3192     3192           
=======================================
+ Hits        16339    16340    +1     
  Misses       2906     2906           
+ Partials      809      808    -1

see 1 file with indirect coverage changes

shilpiprd
shilpiprd suggested changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@shilpiprd shilpiprd left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from these, it all looks good.

doc/posts/2023/2023_06_19_vara_week4.rst Show resolved Hide resolved
doc/posts/2023/2023_06_19_vara_week4.rst Outdated Show resolved Hide resolved
doc/posts/2023/2023_06_19_vara_week4.rst Show resolved Hide resolved
@lb-97 lb-97 force-pushed the blog_branch_2 branch 2 times, most recently from 805d82f to ef068a0 Compare June 21, 2023 14:41
@lb-97
Copy link
Contributor Author

lb-97 commented Jul 5, 2023

@skoudoro, can you approve this PR? Thanks.

skoudoro
skoudoro requested changes Aug 8, 2023
View reviewed changes
Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lb-97,

thank you for this. See below for some comments

doc/posts/2023/2023_06_19_vara_week4.rst Outdated Show resolved Hide resolved
doc/posts/2023/2023_06_19_vara_week4.rst Outdated Show resolved Hide resolved
@lb-97 lb-97 requested a review from skoudoro August 10, 2023 03:18
skoudoro
skoudoro approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update, merging

@skoudoro skoudoro merged commit c8223fa into dipy:master Aug 10, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skoudoro skoudoro skoudoro approved these changes

@pjsjongsung pjsjongsung pjsjongsung approved these changes

@shilpiprd shilpiprd shilpiprd approved these changes

Assignees
No one assigned
Labels
📓type:Documentation 📓
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lb-97 @skoudoro @pjsjongsung @shilpiprd