Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Week 11 Blog #2856

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Adding Week 11 Blog #2856

merged 4 commits into from
Aug 22, 2023

Conversation

shilpiprd
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2856 (c4f7be6) into master (3e9caf8) will increase coverage by 0.00%.
Report is 67 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2856   +/-   ##
=======================================
  Coverage   81.47%   81.47%           
=======================================
  Files         144      144           
  Lines       20054    20063    +9     
  Branches     3192     3194    +2     
=======================================
+ Hits        16339    16347    +8     
- Misses       2906     2907    +1     
  Partials      809      809           

see 3 files with indirect coverage changes

Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before a deeper review, can you

  • check again all the markup:
    • filename, code, function name, etc with backtick
    • remove all the underscore of design matrix
  • make shorter sentences to improve readability

Thanks

@shilpiprd
Copy link
Contributor Author

Yeah, sure !

@shilpiprd
Copy link
Contributor Author

So, I've made some modifications. Please let me know if any change needs to be made in any of the blog posts.
Thanks,

@skoudoro skoudoro merged commit 3976631 into dipy:master Aug 22, 2023
@skoudoro
Copy link
Member

Thanks @shilpiprd, merging

@shilpiprd shilpiprd deleted the 10th_blog branch August 31, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants