Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vara's Week 12 and Week 13 blog #2870

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

lb-97
Copy link
Contributor

@lb-97 lb-97 commented Aug 23, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #2870 (812eded) into master (fa699a9) will not change coverage.
Report is 6 commits behind head on master.
The diff coverage is n/a.

❗ Current head 812eded differs from pull request most recent head 0a25d2b. Consider uploading reports for the commit 0a25d2b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2870   +/-   ##
=======================================
  Coverage   81.48%   81.48%           
=======================================
  Files         144      144           
  Lines       20062    20062           
  Branches     3194     3194           
=======================================
  Hits        16347    16347           
  Misses       2907     2907           
  Partials      808      808           

Copy link
Member

@sreekarchigurupati sreekarchigurupati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it be possible to rotate the output images to match the input axes? Might be better for comparison

@lb-97
Copy link
Contributor Author

lb-97 commented Aug 23, 2023

Will it be possible to rotate the output images to match the input axes? Might be better for comparison

I don't understand, can you explain what input axes are

@sreekarchigurupati
Copy link
Member

sreekarchigurupati commented Aug 23, 2023

image
We need a midsaggital view where the dorsal ventral axis is top-down.

@lb-97
Copy link
Contributor Author

lb-97 commented Aug 23, 2023

image
We need a midsaggital view where the dorsal ventral axis is top-down.

Sure, I can do that. But all of my past visualizations & current ones are in the same plane(anterior-posterior topdown). Rotating these pics alone would lead to confusion. Do let me know your thoughts.

@sreekarchigurupati
Copy link
Member

image
We need a midsaggital view where the dorsal ventral axis is top-down.

Sure, I can do that. But all of my past visualizations & current ones are in the same plane(anterior-posterior topdown). Rotating these pics alone would lead to confusion. Do let me know your thoughts.

It's better to use the standard axes for others to understand it better in the future. But it's fine if it's too much work to redo the visualizations

@lb-97 lb-97 force-pushed the blog_branch_week_12_13 branch 2 times, most recently from 24d2842 to 8b9c197 Compare August 24, 2023 22:10
Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review @sreekarchigurupati and @pjsjongsung.

I am going ahead and merge this PR. Thank @lb-97 !

@skoudoro skoudoro merged commit 5b771e3 into dipy:master Aug 28, 2023
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants