Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of trailing spaces in text files #2894

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

I have tried to leave out generated files.

I have tried to leave out generated files.
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #2894 (413814b) into master (9b689f7) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2894   +/-   ##
=======================================
  Coverage   81.41%   81.41%           
=======================================
  Files         145      145           
  Lines       20147    20147           
  Branches     3217     3217           
=======================================
  Hits        16402    16402           
  Misses       2929     2929           
  Partials      816      816           
Files Changed Coverage Δ
dipy/nn/evac.py 81.50% <ø> (ø)
dipy/nn/synb0.py 53.73% <ø> (ø)
dipy/nn/utils.py 91.66% <ø> (ø)
dipy/reconst/mcsd.py 86.92% <ø> (ø)
dipy/viz/horizon/tab/base.py 89.28% <ø> (ø)
dipy/viz/horizon/tab/cluster.py 62.92% <ø> (ø)
dipy/viz/horizon/tab/peak.py 17.82% <ø> (ø)
dipy/viz/horizon/tab/roi.py 87.87% <ø> (ø)
dipy/viz/horizon/tab/slice.py 54.66% <ø> (ø)
dipy/viz/horizon/visualizer/cluster.py 74.31% <ø> (ø)
... and 3 more

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review September 15, 2023 12:23
Copy link
Contributor

@arokem arokem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

A lot of this is in files that are probably not going to change in the future (e.g., release announcements, blog posts), so not crucial.

I guess we should also tell people somewhere in the dev documentation to set their text editors to take care of this, so it doesn't creep back into the codebase.

Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might add pre-commit in this repo to take care of that in a close future @arokem. Same for the pep8 issues.

Thanks @DimitriPapadopoulos, merging

@skoudoro skoudoro merged commit bb1d3d3 into dipy:master Sep 15, 2023
26 of 30 checks passed
@DimitriPapadopoulos
Copy link
Contributor Author

Indeed pre-commit + ruff would be a good addition for readability. I am cleaning up the code so that such additions become easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants