Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: http:// → https:// #2915

Merged
merged 2 commits into from
Sep 28, 2023
Merged

DOC: http:// → https:// #2915

merged 2 commits into from
Sep 28, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@pep8speaks
Copy link

pep8speaks commented Sep 26, 2023 •
edited

Hello @DimitriPapadopoulos, Thank you for updating !

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated at 2023-09-28 07:42:29 UTC

skoudoro
skoudoro approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you @DimitriPapadopoulos for updating many links also ! merging

@skoudoro
Copy link
Member

oh ok, it is a draft, I can not merge for now. but it looks good for now

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review September 27, 2023 07:31
@DimitriPapadopoulos
Copy link
Contributor Author

I think this merge request ready for a review. The remaining http:// links need extra care to be updated or maybe even removed.

About the PEP8 warnings: I have fixed some of them, I think the remaining ones make no sense. Is it possible to bypass them?

@skoudoro
Copy link
Member

The remaining http:// links need extra care to be updated or maybe even removed.

I agree, it can be done on new PR. Thanks

About the PEP8 warnings: I have fixed some of them, I think the remaining ones make no sense. Is it possible to bypass them?

Yes, it is possible, just add # noqa: E501 at the end of the long sentence/url

e.g : https://www.sphinx-doc.org/en/stable/index.html # noqa: E501

Can you add that then, I can go ahead and merge

@skoudoro
Copy link
Member

Thanks for the update, merging

@skoudoro skoudoro merged commit 060c353 into dipy:master Sep 28, 2023
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skoudoro skoudoro skoudoro approved these changes

Assignees
No one assigned
Labels
📓type:Documentation 📓
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DimitriPapadopoulos @pep8speaks @skoudoro