ENH: MSMT CSD module unique b-val tolerance parameter improvements #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoudoro
reviewed
Oct 5, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2926 +/- ##
==========================================
+ Coverage 81.41% 81.69% +0.28%
==========================================
Files 145 146 +1
Lines 20147 20347 +200
Branches 3217 3226 +9
==========================================
+ Hits 16402 16623 +221
+ Misses 2929 2905 -24
- Partials 816 819 +3
|
Add `tol` parameter missing docstring to MSMT CSD module methods and and functions.
Allow the unique b-val tolerance be a parameter to the `MultiShellDeconvModel` class initialization method.
jhlegarreta
force-pushed
the
AddMSMTAutoResponseParamDocstring
branch
from
54a3f53
to
432b380
Compare
jhlegarreta
changed the title
tol parameter missing docstring
|
Thanks @jhlegarreta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tolparameter missing docstring to MSMT CSD module methodsMultiShellDeconvModel