-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Remove ..figure
directive in examples
#2944
Conversation
* print issue, internal link, * follow sphx-glr syntax convention, * moving import at the top of the file
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2944 +/- ##
==========================================
- Coverage 81.77% 81.71% -0.06%
==========================================
Files 146 147 +1
Lines 20401 20484 +83
Branches 3238 3277 +39
==========================================
+ Hits 16682 16739 +57
- Misses 2901 2913 +12
- Partials 818 832 +14
|
- fix streamlines bad rendering - convert some tutorial to new standard - small others fix for failing tutorial
Ok, this PR is ready to go. is there any comments/suggestions ? I will go ahead and merge this tomorrow at noon if no comments. This cleaning was needed and more to come after the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I spotted a couple of typos along the way, but that doesn't mean there aren't any other ones :-)
Co-authored-by: Ariel Rokem <arokem@gmail.com>
thank you for the review @arokem! For sure there is other ones, like old functions a simpler way to do stuff in many tutorials. We will continue to update that.during the year. |
ps: building the doc in parallel, just waiting the build to finish before merging this PR. |
remove n_frame to record
ok, all good, merging |
Sphinx gallery generate its own figure directive. So, currently our
..figure
directive are not processed and shows unfound files in our tutorials which is confusing.Furthermore, I added
.. rst-class:: centered small fst-italic fw-semibold
directive to simulate and not lose some captions.