[FIX] int_t to npy_intp #2980
Merged
[FIX] int_t to npy_intp #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2980 +/- ##
=======================================
Coverage 81.71% 81.71%
=======================================
Files 147 147
Lines 20569 20569
Branches 3279 3279
=======================================
Hits 16808 16808
Misses 2932 2932
Partials 829 829
|
|
ok, this is ready to go. Can someone have a look before merging ? |
|
Thank you @jhlegarreta for the review. merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Numpy 2.0,
int_ttype is not available anymore and it is not recommended to use it.In our case, it can be safely replaced by
npy_intp.This fix DIPY compilation with Numpy 2.0.
A follow up PR should come today for the tests
PS: #2979