RF: Create PCA denoising utils methods #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jhlegarreta, Thank you for updating ! Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated at 2023-12-10 01:22:45 UTC |
jhlegarreta
commented
Dec 10, 2023
| return np.prod(patch_size) | ||
|
|
||
|
|
||
| def compute_suggested_patch_radius(arr, patch_size): |
There was a problem hiding this comment.
This could have taken arr.shape[-1] as the first argument, but I thought it was less clear from the point of view of the caller.
Create PCA denoising utils methods: refactor code blocks into their own
methods to improve encapsulation.
Add the corresponding tests.
Add a method to report about the dimensionality problem message.
The above allows for the dimensionality problem message to be checked
and filtered in tests.
Fixes:
```
denoise/tests/test_lpca.py::test_mppca_returned_sigma
denoise/localpca.py:194: UserWarning:
Number of samples 27 - 1 < Dimensionality 104.
This might have a performance impact.
Increase patch_radius to 2 to avoid this warning,
or supply suppress_warning=True to your function call.
warn(e_s, UserWarning)
```
reported, for example, at:
https://github.com/dipy/dipy/actions/runs/7146907000/job/19465502675#step:9:4410
jhlegarreta
force-pushed
the
FixPCAWarnings
branch
from
32adde4
to
fe33ea9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3001 +/- ##
=======================================
Coverage 81.71% 81.72%
=======================================
Files 147 147
Lines 20568 20577 +9
Branches 3279 3279
=======================================
+ Hits 16808 16817 +9
Misses 2932 2932
Partials 828 828
|
skoudoro
approved these changes
Dec 10, 2023
There was a problem hiding this comment.
I am ok with this refactoring.
Thanks @jhlegarreta, merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create PCA denoising utils methods: refactor code blocks into their own methods to improve encapsulation.
Add the corresponding tests.
Add a method to report about the dimensionality problem message.
The above allows for the dimensionality problem message to be checked and filtered in tests.
Fixes:
reported, for example, at:
https://github.com/dipy/dipy/actions/runs/7146907000/job/19465502675#step:9:4410