Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RF] Improve scripts and import management #3002

Merged
merged 6 commits into from
Dec 11, 2023

Conversation

skoudoro
Copy link
Member

When running scripts (like dipy_horizon) , too many modules were imported which was not necessary.
This PR:

  • clean this behavior
  • remove unecessary import.
  • remove the script folder (it is now in pyproject.toml)

@pep8speaks
Copy link

pep8speaks commented Dec 10, 2023

Hello @skoudoro, Thank you for updating !

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated at 2023-12-11 05:45:46 UTC

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #3002 (d88933c) into master (ca6268a) will increase coverage by 0.12%.
Report is 16 commits behind head on master.
The diff coverage is 41.17%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3002      +/-   ##
==========================================
+ Coverage   81.71%   81.84%   +0.12%     
==========================================
  Files         147      146       -1     
  Lines       20568    20505      -63     
  Branches     3279     3280       +1     
==========================================
- Hits        16808    16782      -26     
+ Misses       2932     2890      -42     
- Partials      828      833       +5     
Files Coverage Δ
dipy/stats/analysis.py 92.10% <ø> (-0.21%) ⬇️
dipy/workflows/stats.py 85.61% <100.00%> (+0.69%) ⬆️
dipy/viz/horizon/app.py 45.55% <0.00%> (-0.25%) ⬇️
dipy/workflows/cli.py 42.85% <38.46%> (-8.62%) ⬇️

... and 10 files with indirect coverage changes

@Garyfallidis Garyfallidis merged commit 0295dfb into dipy:master Dec 11, 2023
32 of 34 checks passed
@Garyfallidis
Copy link
Contributor

Nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants