TEST: Check and filter PCA dimensionality problem warning #3004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cross-referencing PR #3001. |
|
The warning is gone. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3004 +/- ##
==========================================
- Coverage 81.78% 81.76% -0.02%
==========================================
Files 146 146
Lines 20566 20566
Branches 3281 3281
==========================================
- Hits 16820 16816 -4
- Misses 2911 2914 +3
- Partials 835 836 +1 |
jhlegarreta
force-pushed
the
FixPCAWarnings2
branch
from
d965984
to
50dbfaa
Compare
jhlegarreta
changed the title
Check and filter PCA dimensionality problem warning in MPPCA test.
Fixes:
```
denoise/tests/test_lpca.py::test_mppca_in_phantom
denoise/localpca.py:295: UserWarning:
Number of samples 27 - 1 < Dimensionality 104.
This might have a performance impact.
Increase patch_radius to 2 to avoid this.
warn(dimensionality_problem_message(arr, num_samples, spr), UserWarning)
```
raised, for example, at:
https://github.com/dipy/dipy/actions/runs/7159954273/job/19493785864#step:9:3932
Left behind in commit fe33ea9.
jhlegarreta
force-pushed
the
FixPCAWarnings2
branch
from
50dbfaa
to
52a069f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check and filter PCA dimensionality problem warning in MPPCA test.
Fixes:
raised, for example, at:
https://github.com/dipy/dipy/actions/runs/7159954273/job/19493785864#step:9:3932
Left behind in commit fe33ea9.