Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RF] Fix cython 3 warnings #3026

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

skoudoro
Copy link
Member

@skoudoro skoudoro commented Jan 2, 2024

The PR fixes #3003.

It addresses all Cython 3.x warnings on DIPY codebases. it replaces:

  • nogil with noexcept nogil
  • nogil except -1 with except -1 nogil
  • nogil except * with noexcept nogil

These changes are backward compatible with Cython 0.29.33 but we aim to use only Cython 3.x soon

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8caa6c5) 82.08% compared to head (d7a0f0a) 82.06%.
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3026      +/-   ##
==========================================
- Coverage   82.08%   82.06%   -0.02%     
==========================================
  Files         146      146              
  Lines       20467    20467              
  Branches     3261     3261              
==========================================
- Hits        16800    16796       -4     
- Misses       2856     2859       +3     
- Partials      811      812       +1     
Files Coverage Δ
dipy/core/sphere.py 93.30% <82.35%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks for doing this Serge !

@jhlegarreta jhlegarreta merged commit b45dbde into dipy:master Jan 8, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DIPY installation raises Cython warnings
2 participants