Bugfix: Horizon image's dtype validation #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3031 +/- ##
==========================================
+ Coverage 82.08% 82.11% +0.02%
==========================================
Files 146 146
Lines 20467 20495 +28
Branches 3261 3268 +7
==========================================
+ Hits 16800 16829 +29
+ Misses 2856 2855 -1
Partials 811 811
|
skoudoro
reviewed
Jan 8, 2024
There was a problem hiding this comment.
Hi @maharshi-gor,
Looks good to me. See below a very small comment but this PR is ready to be merged.
Thanks!
dipy/viz/tests/test_apps.py
Outdated
Comment on lines
137
to
142
| def check_for_warnings(warn_printed, w_msg): | ||
| selected_w = [w for w in warn_printed if issubclass(w.category, | ||
| UserWarning)] | ||
| assert len(selected_w) >= 1 | ||
| msg = [str(m.message) for m in selected_w] | ||
| npt.assert_equal(w_msg in msg, True) |
There was a problem hiding this comment.
this function is duplicated.
Maybe you should moved this function in dipy.testing.__init__.py
dipy/viz/tests/test_util.py
Outdated
Comment on lines
29
to
34
| def check_for_warnings(warn_printed, w_msg): | ||
| selected_w = [w for w in warn_printed if issubclass(w.category, | ||
| UserWarning)] | ||
| assert len(selected_w) >= 1 | ||
| msg = [str(m.message) for m in selected_w] | ||
| npt.assert_equal(w_msg in msg, True) |
There was a problem hiding this comment.
duplicated, to move somewhere else
dipy/viz/horizon/util.py
Outdated
|
|
||
|
|
||
| def check_img_dtype(images): | ||
| """Check for supported dtype. If not supported numerical type, fallback to |
There was a problem hiding this comment.
after the first . you should return to a new line. see here for an example
skoudoro
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue #2789 about checking dtype of the passed image arrays.
Current behavior
Proposed behavior
All the images will be checked for dtype and the following cases can be the result.