Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small refactoring to remove the
cpdef
in pmf.pyx.cpdef = def + cdef
, so it does not make sense to have cpdef + cdef. it is eitherdef +cdef
orcpdef
I also use the opportunity to replace some pointer by memoryview. When using memoryview, we should make sure to use aligned memory by using [::1] for speed reason.
@gabknight, can you have a look and try?