Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF - changed memory view to double* trilinear_interpolation_4d #3090

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

gabknight
Copy link
Contributor

@gabknight gabknight commented Feb 29, 2024

  • Changed the out type from memoryview to double* in dipy.core.interpolation.trilinear_interpolation_4d_c. This allows for the use of trilinear_interpolation4d_c in pure cython. In particular when the out needs to be instanciated in cython. This is relevant for PR WIP - Parallel Tracking Framework #3089
  • Replaced dipy.core.interpolation.trilinear_interpolation_4d declaration to def from cpdef

@skoudoro
Copy link
Member

Thank you for this @gabknight.

Waiting for the CI's

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (890e49a) to head (fe4bfe6).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3090      +/-   ##
==========================================
+ Coverage   82.37%   82.39%   +0.01%     
==========================================
  Files         146      146              
  Lines       20640    20640              
  Branches     3320     3320              
==========================================
+ Hits        17002    17006       +4     
+ Misses       2807     2804       -3     
+ Partials      831      830       -1     

see 1 file with indirect coverage changes

Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you @gabknight! merging

@skoudoro skoudoro merged commit 55ea433 into dipy:master Mar 1, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants