Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: volume synchronizing #3092

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Conversation

maharshi-gor
Copy link
Member

Feature: Volume Synchronizing

This PR introduces the changes for a feature where the volume slider will be synchronized.

When to synchronize

  • All the provided images have the same shape.
  • All the images with volume should have the same volume samples.

Behavior Expectation

Images with the same shape and same volumes
The slices will be synchronized and volumes will also be synchronized.

Images with the same shape but different volumes
The slices will be synchronized but volumes will not be synchronized.

Images with different shapes but same volumes and Images with different shapes and different volumes
Nothing will be synchronized and a warning will be visible.

@maharshi-gor maharshi-gor added the category:visualization everything related to viz label Mar 1, 2024
@maharshi-gor maharshi-gor self-assigned this Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 82.34%. Comparing base (fe4bfe6) to head (529a3fd).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3092      +/-   ##
==========================================
- Coverage   82.39%   82.34%   -0.06%     
==========================================
  Files         146      146              
  Lines       20640    20664      +24     
  Branches     3320     3328       +8     
==========================================
+ Hits        17006    17015       +9     
- Misses       2804     2817      +13     
- Partials      830      832       +2     
Files Coverage Δ
dipy/viz/horizon/app.py 45.55% <100.00%> (ø)
dipy/viz/horizon/util.py 97.67% <100.00%> (+0.45%) ⬆️
dipy/viz/horizon/tab/base.py 71.02% <41.66%> (-1.01%) ⬇️
dipy/viz/horizon/tab/slice.py 49.24% <20.00%> (-1.81%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maharshi-gor,

Looks good to me. I just need to do a quick local tests and then merging

@skoudoro skoudoro merged commit 94579b4 into dipy:master Mar 4, 2024
27 of 30 checks passed
@skoudoro
Copy link
Member

skoudoro commented Mar 4, 2024

Thanks @maharshi-gor, merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:visualization everything related to viz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants