Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dkimaskfix #3104

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Dkimaskfix #3104

merged 2 commits into from
Mar 7, 2024

Conversation

samcoveney
Copy link
Contributor

Extra fixes for masking for NLLS DKI which solves #3033

@pep8speaks
Copy link

pep8speaks commented Mar 7, 2024

Hello @samcoveney, Thank you for updating !

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated at 2024-03-07 15:11:01 UTC

@samcoveney
Copy link
Contributor Author

samcoveney commented Mar 7, 2024

Hi @skoudoro I think I have finished off your pull request #3033 Please ensure you are still listed as an author in the pull request, in case I destroyed that information somehow...

Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finalizing this @samcoveney,

LGTM, merging

@skoudoro skoudoro merged commit 84c1b79 into dipy:master Mar 7, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants