Fix pep8 errors in viz #908
Conversation
|
Thanks for contributing. I don't think you did anything wrong. I believe the failures on the Travis bot are due to updates in our dependencies. I'll post an issue about this, but we'll hold off on merging this in, until we can sort that out. |
| @@ -56,7 +55,8 @@ def sph_project(vertices, val, ax=None, vmin=None, vmax=None, cmap=None, | |||
| -------- | |||
| >>> from dipy.data import get_sphere | |||
| >>> verts = get_sphere('symmetric724').vertices | |||
| >>> ax = sph_project(verts.T, np.random.rand(len(verts.T))) # skip if not has_basemap | |||
| >>> ax = sph_project(verts.T, np.random.rand(len(verts.T))) # skip | |||
There was a problem hiding this comment.
Sorry - I was wrong. This change is the change that causes the test failures in the bots. Please change this line back.
This causes Travis to skip this test, when basemap is not present, and the Travis set up doesn't (usually) have this package.
|
It is still inside the comment right? Changing it back gives the pep8 line too long. So can I solve it somehow? |
|
Nope. Sometimes we just have to live with PEP8 violations: https://www.python.org/dev/peps/pep-0008/#a-foolish-consistency-is-the-hobgoblin-of-little-minds |
|
In it goes. Thanks for the fix! |
|
thanks, Ill get back at the other pep8 s :) |
fixes #890