Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for past observations #25

Closed
Tracked by #10
TomWagg opened this issue Sep 9, 2022 · 0 comments
Closed
Tracked by #10

Account for past observations #25

TomWagg opened this issue Sep 9, 2022 · 0 comments
Assignees
Labels
todo Something to do
Milestone

Comments

@TomWagg
Copy link
Collaborator

TomWagg commented Sep 9, 2022

Currently the way I have it set up is that the algorithm doesn't account for any observations prior to the detection window. This leaves us with 3 cases

  1. It hasn't been observed before
  2. It has been observed at least twice on a previous night but not enough to be detected
  3. It's been previously detected

For 1, we proceed as usual. For 3, we should remove these objects from the run since we've already found them.

2 is more complicated but I propose we do the following. For each object, pass a list/dict of nights on which 2 observations have occurred that meet the usual criteria. We can then prepend this to unique_nights in get_probability_by_id and run it in exactly the same way.

@TomWagg TomWagg self-assigned this Sep 9, 2022
@TomWagg TomWagg added the todo Something to do label Sep 9, 2022
@TomWagg TomWagg added this to the First draft milestone Sep 9, 2022
@TomWagg TomWagg closed this as completed in 479fa86 Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo Something to do
Projects
None yet
Development

No branches or pull requests

1 participant