Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

API saves ISO datetime wrong #563

Closed
rijkvanzanten opened this issue Nov 2, 2018 · 6 comments
Closed

API saves ISO datetime wrong #563

rijkvanzanten opened this issue Nov 2, 2018 · 6 comments

Comments

@rijkvanzanten
Copy link
Member

Bug Report

If I send 1995-12-29T08:00+02:00 to the api, it saves 1995-12-29 08:00 disregarding the timezone.

@rijkvanzanten rijkvanzanten added the bug Something isn't working label Nov 2, 2018
@rijkvanzanten rijkvanzanten added this to Needs triage in Bug Triage via automation Nov 2, 2018
@rijkvanzanten rijkvanzanten moved this from Needs triage to Critical in Bug Triage Nov 2, 2018
@wellingguzman
Copy link
Contributor

The format in your example is missing the seconds. Unfortunately the API only supports on ISO date time format 1995-12-29T08:00:00+02:00.

Ideally will be great to support all date time formats.

The problem here is that we need to confirm is an ISO format before trying to convert them to UTC. It need to rethink how date time are save.

@benhaynes
Copy link
Sponsor Member

@rijkvanzanten – for now can we just have interfaces always submit with seconds?

@rijkvanzanten
Copy link
Member Author

Ref #536

@benhaynes benhaynes moved this from Critical to High priority in Bug Triage Nov 4, 2018
@benhaynes benhaynes added this to To do in v2.0.7 Nov 12, 2018
@rijkvanzanten rijkvanzanten added this to To do in v2.0.8 Nov 14, 2018
@rijkvanzanten rijkvanzanten added this to To do in v2.0.9 Nov 17, 2018
@stale
Copy link

stale bot commented Jan 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 1, 2019
@benhaynes benhaynes removed the stale label Jan 2, 2019
@benhaynes benhaynes added this to To do in v2.0.14 via automation Jan 2, 2019
@wellingguzman wellingguzman added enhancement New feature or request and removed bug Something isn't working labels Jan 4, 2019
@wellingguzman
Copy link
Contributor

This is actually not a bug, but a feature request to support more ISO formats, rather than just 1995-12-29T08:00:00+02:00. For example, without minutes or minutes and seconds.

@wellingguzman wellingguzman moved this from To do to In progress in v2.0.14 Jan 4, 2019
Bug Triage automation moved this from High priority to Closed Jan 4, 2019
v2.0.14 automation moved this from In progress to Done Jan 4, 2019
@wellingguzman
Copy link
Contributor

There's three format supported all include full date and time.

Example:

Using time offset
2019-01-04T16:12:05+00:00

Ussing Z
2019-01-04T16:12:05Z

Using Z without Dashes
20190104T161205Z

Implemented by 93a0dfa

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Bug Triage
  
Closed
v2.0.14
  
Done
v2.0.7
  
To do
v2.0.8
  
To do
v2.0.9
  
To do
Development

No branches or pull requests

3 participants