Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could "layout python-venv" be made available by default? #537

Closed
nottrobin opened this issue Nov 11, 2019 · 6 comments
Closed

Could "layout python-venv" be made available by default? #537

nottrobin opened this issue Nov 11, 2019 · 6 comments
Labels

Comments

@nottrobin
Copy link

I'm not sure why we need to create the layout_python-venv bash function ourselves (as per https://github.com/direnv/direnv/wiki/Python).

Would it be possible to provide layout python-venv by default? As it's probably superior to layout python for modern use-cases.

@tlgs
Copy link

tlgs commented Jan 4, 2020

Agreed, since venv is part of the Python Standard Library I think it makes a lot of for it to be supported natively.

I would even argue that layout python should use it instead of virtualenv but I understand Python's environment management is VERY messy and that a lot of solutions rely on older approaches...

@zimbatm
Copy link
Member

zimbatm commented Jan 5, 2020

I try to keep direnv as backward-compatible as possible. If you can make that change without breaking existing users then why not. This should include users who used and old installation of direnv and upgraded.

@tlgs
Copy link

tlgs commented Jan 22, 2020

It seems venv is already being used for layout python in the master branch; it just hasn't made it to a release yet. It was added by @eddies.

I don't think it works as the python-venv in the community wiki though...

@zimbatm
Copy link
Member

zimbatm commented Jan 22, 2020

I am going to cut a release soon so let me know if it needs some fixing

@NilsIrl
Copy link

NilsIrl commented Apr 14, 2020

From what I understand, on the latest release thanks to #505 layout python will use venv by default.

@NilsIrl
Copy link

NilsIrl commented Apr 14, 2020

So this can be closed I guess

@zimbatm zimbatm closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants