Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Update wasmer? #22

Open
gaborcsardi opened this issue Dec 7, 2021 · 6 comments
Open

Update wasmer? #22

gaborcsardi opened this issue Dec 7, 2021 · 6 comments

Comments

@gaborcsardi
Copy link

I cannot build it now on macOS with the latest (rustup update) tools:

error[E0425]: cannot find function `get_fault_info` in this scope
   --> /Users/gaborcsardi/.cargo/registry/src/github.com-1ecc6299db9ec823/wasmer-runtime-core-0.17.1/src/fault.rs:289:21
    |
289 |         let fault = get_fault_info(siginfo as _, ucontext);
    |                     ^^^^^^^^^^^^^^ not found in this scope

updating the wasmer version to 0.17.1 does not help, either.

Do you think it is possible to move to the new wasmer crate?

@dirkschumacher
Copy link
Owner

Yeah definitely possible. I haven't touched it since I got a Mac M1 (#20), because I could not compile it. I also have not followed the development of wasmer (and wasmtime) in recent months and things will likely break I guess.

@gaborcsardi
Copy link
Author

I don't think the issue is M1 related, but I'll try it on Intel as well. I think wasmer-runtime-core is simply not supported any more, and wasmer is the way to go now. At least this is my high level understanding.

@syrusakbary
Copy link

Latest wasmer should support and compile on macOS M1 (I'm writing here from a M1 Max!), let me know if we can help on anything there :)

@dirkschumacher
Copy link
Owner

dirkschumacher commented Dec 9, 2021

Ok, will try to make a PR 🤞

@dirkschumacher
Copy link
Owner

The current implementation relies heavily on the API exposed in wasmer-c-api. Good examples are now here: https://docs.wasmer.io/integrations/examples

I think it will make sense to rewrite the C++ part.

@dirkschumacher
Copy link
Owner

I think it make sense to completely rewrite it and move it very closely to the Wasmer API, similar to the other language bindings. With classes/functions for concepts like Engine, Store, Module, etc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants