Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no arrow functions in clientside linting #56

Open
aflaherty13 opened this issue Mar 20, 2018 · 2 comments
Open

no arrow functions in clientside linting #56

aflaherty13 opened this issue Mar 20, 2018 · 2 comments
Assignees

Comments

@aflaherty13
Copy link
Contributor

Arrow functions are a fairly recent addition to javascript, we should try and avoid them for the client side code as it will not run on older browsers. Essentially any browser only a few versions back, eg a few years old, this would include a lot of existing mobile browsers. This would prevent the user from using the registration and from logging in.

Uncaught SyntaxError: Unexpected token =>
login.js:1 Uncaught SyntaxError: Unexpected token )
@aflaherty13
Copy link
Contributor Author

This will require reverting a lot of the clientside linting and removing the arrow functions from the es-lint client config.

@dmcfaddengalway
Copy link
Contributor

I think for right now, we ought to just leave it and work on getting database filling in, we can always go back later for this. But I see the importance of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants