Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 17 support #23

Open
zanedev opened this issue Jul 13, 2021 · 1 comment
Open

React 17 support #23

zanedev opened this issue Jul 13, 2021 · 1 comment

Comments

@zanedev
Copy link

zanedev commented Jul 13, 2021

Can you add react 17 peer support? --legacy-peer-deps seems to work for now

npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.5.4 || ^16.0.0" from react-scroll-up-button@1.6.4
npm ERR! node_modules/react-scroll-up-button
npm ERR!   react-scroll-up-button@"^1.6.4" from the root project```
@ProsperousHeart
Copy link

ProsperousHeart commented Feb 6, 2023

+1 on the work around ... but I'm a bit concerned about doing this since there could be other reasons other than the react version restrictions

I may take a stab at testing my theory though

A fix no this soon would be great because a bunch of errors happen when you try to update your other npm packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants