Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dockerfile for testing #2

Merged
merged 1 commit into from Aug 31, 2020
Merged

Add Dockerfile for testing #2

merged 1 commit into from Aug 31, 2020

Conversation

me-diru
Copy link
Owner

@me-diru me-diru commented Aug 31, 2020 •
edited

  • Testing integration with MusicBrainz
  • Add steps to dockerize SB_API

@me-diru me-diru force-pushed the sb-api branch 4 times, most recently from 5a9ef51 to 1c30a75 Compare August 31, 2020 15:10
yvanzo
yvanzo suggested changes Aug 31, 2020
View reviewed changes
Copy link

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockerfile works for testing and it is the most important for now.
Further customization will have to be done later on.
Just spotted a few typos.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@me-diru
Add Dockerfile for testing
53f9ac6 
- Testing integration with MusicBrainz
- Add documentation for the same
@me-diru
Copy link
Owner Author

me-diru commented Aug 31, 2020

Dockerfile works for testing and it is the most important for now.
Further customization will have to be done later on.
Just spotted a few typos.

Thank you for your time and review.

@me-diru me-diru merged commit 3b4eca5 into master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvanzo yvanzo yvanzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@me-diru @yvanzo