gateway - received exception when parsing ActivityButton

[chrissound]

Using 1.12.5 (will try upgrade - just need to upgrade the all the code first)

gateway - received exception [Error in $: Error in $.activities[0].buttons[0]: parsing ActivityButton failed, expected Object, but encountered String] while decoding:

(I've redacted the sensitive values of a user).

{
  "t": "PRESENCE_UPDATE",
  "s": 91,
  "op": 0,
  "d": {
    "user": {
      "id": "****************"
    },
    "status": "online",
    "guild_id": "************************",
    "client_status": {
      "web": "idle",
      "mobile": "online",
      "desktop": "idle"
    },
    "activities": [
      {
        "type": 0,
        "timestamps": {
          "start": *********************8
        },
        "state": "🎮 Connected: ❌ | 🔋 N/A",
        "session_id": "*****************",
        "name": "*******",
        "id": "**********************",
        "details": "Home Page | v2.4.2",
        "created_at": **************8,
        "buttons": [
          "DSX - View On Steam",
          "DSX - Join Discord Server"
        ],
        "assets": {
          "large_image": "*********************"
        },
        "application_id": "*****************************"
      }
    ]
  }
}

[L0neGamer]

I can see what the issue is, it's exactly as described; when sending a presence update, we need it to be an object of a label and a string, but when receiving it will just be a string. It's a simple thing to fix with a plaster but it'll require a bit more thinking to get a satisfying solution; will probably need different types for sending and receiving.

[chrissound]

Hmmm, potentially ActivityButton becomes a sum type then? And then you'll have ActivityButtonIncoming String | ActivityButtonOutgoing ...?

[L0neGamer]

The issue with that in my eyes is that it doesn't ensure what type you'll get on either the receiving end or what you can send; a library user should know that they can only receive one type, and they can only send the other. Not sure that we do this anywhere else though...