Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include reactions in Message type #56

Closed
LukaHorvat opened this issue Nov 20, 2020 · 2 comments
Closed

Include reactions in Message type #56

LukaHorvat opened this issue Nov 20, 2020 · 2 comments

Comments

@LukaHorvat
Copy link

So I don't know if this is a newer change in the API but reactions are now returned when querying messages (even in bulk). The current type https://github.com/aquarial/discord-haskell/blob/master/src/Discord/Internal/Types/Channel.hs#L229 doesn't have a reactions field as documented in https://discord.com/developers/docs/resources/channel#message-object.

In my testing, the field is missing if there are no reactions.

@aquarial
Copy link
Collaborator

Interesting. Might be new, might have overlooked. Added MessageReaction to Message field, good note that the field is missing if no reactions.

It's got different fields than the ReactionInfo that comes with MessageReactionAdd, so I had to add a struct.

Potentially confusing that , but I'm not sure what else to do.

@LukaHorvat
Copy link
Author

Cool! Thanks for the quick work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants