Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.0.0 #46

Closed
davidcole1340 opened this issue Mar 27, 2016 · 6 comments
Closed

Version 4.0.0 #46

davidcole1340 opened this issue Mar 27, 2016 · 6 comments
Assignees

Comments

@davidcole1340
Copy link
Member

This is an issue post to gather all information about Version 4.0.0.

Current changes:

  • New caching system
  • Dependency injection
  • Part factories
  • REST client will be passed around instead of using static methods
@davidcole1340
Copy link
Member Author

@aequasi since everything will be non-static, what do you think about having drivers for the REST client so that we can use the ReactPHP HTTP Client for async requests and use Guzzle when not using the WebSocket?

@davidcole1340 davidcole1340 added this to the v4.0.0 milestone Mar 27, 2016
@cryptiklemur
Copy link
Contributor

I think that's a really good idea.

@davidcole1340
Copy link
Member Author

@aequasi what do you think about having promises everywhere? There are some things that don't need promises but should we still use promises so that it is consistent?

@davidcole1340
Copy link
Member Author

I haven't converted these methods yet as they don't use HTTP requests:

- Channel::getOverwritesAttribute()
- Guild::getRolesAttribute()

@cryptiklemur
Copy link
Contributor

being consistent is generally a good idea, i'd say lets put them everywhere

@davidcole1340
Copy link
Member Author

Version 4 being released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants