Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-RateLimit-Reset and Retry-After Ratelimit headers #127

Closed
ghost opened this issue Aug 23, 2016 · 2 comments
Closed

X-RateLimit-Reset and Retry-After Ratelimit headers #127

ghost opened this issue Aug 23, 2016 · 2 comments

Comments

@ghost
Copy link

ghost commented Aug 23, 2016

After hitting the ratelimit a few times through the ratelimit-compliant RequestBuffer in the Discord4J Java API, I visited the docs for ratelimits in search for an answer -- why was I hitting the ratelimit. I found @hydrabolt commenting about the use of X-RateLimit-Reset instead of Retry-After. (#108) image As @night doesn't see a need to replace X-RateLimit-Reset with Retry-After, may I politely ask you guys to implement both headers please?

Edit 2: As @satom99 pointed out, although there is a Date header, it would be better to also include the Retry-After header, as recommended on RFC-6585

@satom99
Copy link

satom99 commented Aug 23, 2016

Someone, perhaps @night himself, pointed out the Date header. Which, being Discord's time UTC, may be used to get the exact time before the payload is generated - and thus do a simple subtraction.

@b1naryth1ef
Copy link
Contributor

The Retry-After header still exists for ratelimited requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants