Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mass-reaction add action #1301

Closed
Andre601 opened this issue Jan 8, 2020 · 6 comments
Closed

Implement mass-reaction add action #1301

Andre601 opened this issue Jan 8, 2020 · 6 comments

Comments

@Andre601
Copy link
Contributor

Andre601 commented Jan 8, 2020

I think it would be beneficial for both Bot developers and the Discord API to implement a API endpoint(?) to add multiple reactions at once, instead of making a RestAction call for each separate reaction itself, which requires pauses/delays in between due to ratelimits.

This may require changes to how reactions are currently added, by either allowing the reactions to be provided through a JSON body (Probably the best way if PUT supports this) or by having the reactions listed in the path itself, perhaps separated by a specific character like a comma or dot.

This would, again, improve both the API and bots as it could reduce calls being made on the API as you would only need to make one call for lets say 5 reactions instead of 5 separated calls.

@NovusTheory
Copy link

This request was already rejected: #182 (comment)

@Andre601
Copy link
Contributor Author

Andre601 commented Jan 8, 2020

While this is true can we not ignore the fact that said issue is more than 5 years old by now.
And in 5 years can opinion change.

I don't request that the API would allow adding 20 reactions at once (at the same time) to a message, but that the bot can send a collection of reactions (perhaps with a max limit) and the api would add them one by one, to not cause possible issues with the clients.

I already stated that this could have possible benefits for both sides (decreased API calls and CPU usage for the bot).

@msciotti
Copy link
Contributor

msciotti commented Jan 8, 2020

The case for mass-adding reactions is to act as pseudo buttons for embeds. Reactions are already a really flaky thing, and break when a lot of them get added (as can be seen on almost all role-assignment-by-reaction bots on large servers).

Investing more into this use case is not a great use of effort as opposed to building a button system.

I know that it means that it's still a bit annoying in the interim with needing to one-by-one add reactions, and I apologize. But we don't want to invest any more in this use case right now.

@msciotti msciotti closed this as completed Jan 8, 2020
@Mee42
Copy link

Mee42 commented Jan 8, 2020

Is there any work/active consideration of a button system, as of right now?

@jhgg
Copy link
Member

jhgg commented Jan 8, 2020

I've personally been wanting buttons for years, but it's actually quite difficult to do. But there is consideration. No promises though.

@jhgg jhgg reopened this Jan 8, 2020
@jhgg jhgg closed this as completed Jan 8, 2020
@Andre601
Copy link
Contributor Author

Andre601 commented Jan 8, 2020

accidentally clicked on "Comment and reopen?" 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants