Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The client throws an error when response_type is token in command AUTHORIZE #47

Open
kuylar opened this issue Mar 20, 2024 · 1 comment

Comments

@kuylar
Copy link

kuylar commented Mar 20, 2024

First of all, I know that using response_type: token is not meant to be used in Embedded Apps. However, while writing an SDK wrapper for Godot, I decided to try sending it to check if it would work.

The API request succeeded, but I got this error as a response, instead of a normal error message telling me to use response_type: code instead (that's what I expected to get).

{
    "code": 1000,
    "message": "Cannot read properties of undefined (reading 'split')"
}

After checking the API side, I found out that the response was successful, but my theory is that the client splits the response string by ?, expecting the code to be in there, but since the token url data is in the hash instead of in the query, this throws an exception.

Would love to hear more about this. Thanks in advance!

@matthova
Copy link
Collaborator

Great callout. We do not support implicit flows for activities and will update the RPC server to notify users accordingly. I'll leave this issue open for now and hope to close it once a better error is surfaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants