detach fiber from dom

discord · Jun 6, 2019 · 2e5ee2f · 2e5ee2f
1 parent d28ee48
commit 2e5ee2f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/packages/react-dom/src/client/ReactDOMComponentTree.js b/packages/react-dom/src/client/ReactDOMComponentTree.js
@@ -8,11 +8,11 @@
 import {HostComponent, HostText} from 'shared/ReactWorkTags';
 import invariant from 'shared/invariant';
 
-const randomKey = Math.random()
-  .toString(36)
-  .slice(2);
-const internalInstanceKey = '__reactInternalInstance$' + randomKey;
-const internalEventHandlersKey = '__reactEventHandlers$' + randomKey;
+// const randomKey = Math.random()
+//   .toString(36)
+//   .slice(2);
+const internalInstanceKey = '__reactInternalInstance$';
+const internalEventHandlersKey = '__reactEventHandlers$';
 
 export function precacheFiberNode(hostInst, node) {
   node[internalInstanceKey] = hostInst;

diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.js b/packages/react-reconciler/src/ReactFiberCommitWork.js
@@ -728,6 +728,9 @@ function commitUnmount(current: Fiber): void {
     }
     case HostComponent: {
       safelyDetachRef(current);
+      // HACK: detach fiber references from DOM
+      current.stateNode.__reactEventHandlers$ = null;
+      current.stateNode.__reactInternalInstance$ = null;
       break;
     }
     case HostPortal: {