-
-
Notifications
You must be signed in to change notification settings - Fork 37
Conversation
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 18 +3
Lines 144 227 +83
Branches 21 33 +12
=========================================
+ Hits 144 227 +83
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this feels more like a copy-paste from d.js (fair), without any input validation or such. Should probably get some of that rolling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Embed
methods should return this
instead of Embed
to allow for chaining from extending classes.
I think this should check if all the properties are valid before setting them, like check if the title provided in |
That's what Vlad suggested in #11 (comment) but we're waiting on a response from the |
I pinged the other two to reach a consensus about passing in data in the constructor, not validating builder methods inputs :D Also this needs a rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM.
Any questions, hit me up @Fyko! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may leave your complaints in my DMs 😬
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Co-authored-by: DTrombett <73136330+DTrombett@users.noreply.github.com> Co-authored-by: Antonio Román <kyradiscord@gmail.com> Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com> Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Please describe the changes this PR makes and why it should be merged:
This PR creates an
Embed
builder. Closes #10Status and versioning classification: