Skip to content
This repository has been archived by the owner on Jan 8, 2022. It is now read-only.

fix(SlashCommandBuilder): allow subcommands and groups to coexist at the root level #26

Merged
merged 4 commits into from
Aug 21, 2021

Conversation

Khasms
Copy link
Contributor

@Khasms Khasms commented Aug 17, 2021

Please describe the changes this PR makes and why it should be merged:
As shown in #25 and as confirmed to me in DAPI, the root level of slash commands supports having both subcommands and subcommand groups, but builders does not. This PR removes the checks that prevented this and updates the relevant types. Also, the new return type name is quite lengthy so I'm open to suggestions on a more concise name.

fix #25

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #26 (60e9fad) into main (2aecbe4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          144       139    -5     
  Branches        21        19    -2     
=========================================
- Hits           144       139    -5     
Impacted Files Coverage Δ
.../interactions/slashCommands/SlashCommandBuilder.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aecbe4...60e9fad. Read the comment docs.

@Khasms Khasms requested a review from kyranet August 20, 2021 06:55
@iCrawl iCrawl merged commit 0be4daf into discordjs:main Aug 21, 2021
@Khasms Khasms deleted the mixing-subcommands branch August 22, 2021 00:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't mix subcommands and subcommand groups at the root level
5 participants