Skip to content
This repository has been archived by the owner on Jan 8, 2022. It is now read-only.

feat(ContextMenus): add context menu command builder #29

Merged
merged 12 commits into from
Oct 18, 2021

Conversation

Khasms
Copy link
Contributor

@Khasms Khasms commented Aug 22, 2021

Please describe the changes this PR makes and why it should be merged:
Adds context menu command builders according to the docs here and here.

close #28

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2021

Codecov Report

Merging #29 (5f19cce) into main (c0f7993) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        21    +3     
  Lines          233       264   +31     
  Branches        33        33           
=========================================
+ Hits           233       264   +31     
Impacted Files Coverage Δ
.../interactions/slashCommands/SlashCommandBuilder.ts 100.00% <ø> (ø)
src/interactions/contextMenuCommands/Assertions.ts 100.00% <100.00%> (ø)
...s/contextMenuCommands/ContextMenuCommandBuilder.ts 100.00% <100.00%> (ø)
...s/slashCommands/mixins/CommandChannelOptionBase.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f7993...5f19cce. Read the comment docs.

@monbrey
Copy link
Member

monbrey commented Aug 23, 2021

Not sure I'd agree that this should be completely separate to the current Slash Command builder - with refactoring a lot of code duplication could be reduced.

@whirlxd
Copy link

whirlxd commented Sep 1, 2021

Is there any eta as of yet on when this is getting merged?

@vladfrangu
Copy link
Member

At least 1 day till I fly back home, wrap up another -types release, publish it, and get it here (since it depends on it to be able to proceed)

@skyeredwood
Copy link

Any update on the ETA for this?

@vladfrangu
Copy link
Member

@Khasms you can pull the main branch and then this PR should be ready 👍

@milanmdev
Copy link

any ETA for when this will be merged?

@ChrisSch-dev
Copy link

Any ETA of it being merged?

Co-authored-by: Nicholas Christopher <nicholaschristopher@protonmail.com>
@iCrawl iCrawl merged commit f0641e5 into discordjs:main Oct 18, 2021
@Khasms Khasms deleted the context-menus branch November 30, 2021 20:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🎉Context Menu Builders!