Skip to content
This repository has been archived by the owner on Jan 8, 2022. It is now read-only.

fix: properly type toJSON methods #34

Merged
merged 1 commit into from
Aug 29, 2021

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented Aug 28, 2021

Please describe the changes this PR makes and why it should be merged:

Adds return types for toJSON that correspond with discord-api-types

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@codecov-commenter
Copy link

Codecov Report

Merging #34 (3695209) into main (2aecbe4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        18    +3     
  Lines          144       233   +89     
  Branches        21        33   +12     
=========================================
+ Hits           144       233   +89     
Impacted Files Coverage Δ
.../interactions/slashCommands/SlashCommandBuilder.ts 100.00% <ø> (ø)
...eractions/slashCommands/SlashCommandSubcommands.ts 100.00% <ø> (ø)
src/interactions/slashCommands/Assertions.ts 100.00% <0.00%> (ø)
...nteractions/slashCommands/mixins/CommandOptions.ts 100.00% <0.00%> (ø)
...s/slashCommands/mixins/CommandOptionWithChoices.ts 100.00% <0.00%> (ø)
src/messages/embed/Embed.ts 100.00% <0.00%> (ø)
src/messages/embed/Assertions.ts 100.00% <0.00%> (ø)
src/interactions/slashCommands/options/number.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aecbe4...3695209. Read the comment docs.

@iCrawl iCrawl merged commit 7723ad0 into discordjs:main Aug 29, 2021
@kyranet kyranet linked an issue Sep 7, 2021 that may be closed by this pull request
Khasms pushed a commit to Khasms/builders that referenced this pull request Sep 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface for SlashCommandBuilder#toJSON()
5 participants